-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OpenTelemetry substitution #25158
Conversation
/cc @radcortez |
Any chance we could test this somehow? Not necessarily the whole thing but at least that this thing compiles? |
We could add the extension to one of the integration tests. @radcortez anything more we can do? |
We can also add some integrations tests, set up Jaeger, and check if the Telemetry data is getting correctly populated. It is going to require some effort. Not sure if it will be worth it since the plan is to move the Jaeger extension to Quarkiverse and deprecate it at some point. The recommended way to push Telemetry data is to use the OTel Exporter (which can push data to Jaeger on its own, so we don't need a dedicated extension for Jaeger). |
So do you propose we just leave it as is for now? |
Yes. We can just add an integration-test to make sure that the compile works. |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
App with quarkus-opentelemetry-exporter-jaeger builds now
Thanks for checking! |
Fixes: #25143